feat(otap-dataflow): [WIP] add live internal log streaming to the admin UI#2620
Draft
lalitb wants to merge 8 commits intoopen-telemetry:mainfrom
Draft
feat(otap-dataflow): [WIP] add live internal log streaming to the admin UI#2620lalitb wants to merge 8 commits intoopen-telemetry:mainfrom
lalitb wants to merge 8 commits intoopen-telemetry:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (61.47%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 88.14% 88.09% -0.06%
==========================================
Files 633 633
Lines 235806 236291 +485
==========================================
+ Hits 207862 208153 +291
- Misses 27420 27614 +194
Partials 524 524
🚀 New features to boost your workflow:
|
Contributor
|
Could you add a screenshot showing the controls to display / hide the log tap panel. |
Member
Author
I added that now. This PR originally did not include a separate show/hide control for the Internal Logs panel, but it does now, and I’ve also added screenshots showing the display/hide control and the panel state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds live internal log viewing to the embedded admin UI.
It introduces:
Implementation notes:
log_tapnow supports live subscribers in addition to retained-log queriesUser-facing behavior:
When admin UI opened, the log panel is disabled.
When enabled: