AltairZ80: Improved choice of boot ROM#512
Conversation
Adds support for the ISO/European "left backslash" or "less than" key. It's found between left shift and Z.
This emulates the classic LINC. The design was settled in 1965, increasing memory to 2048 words, and adding a Z register, an overflow flag, and an interrupt facility.
These are tests for the classic LINC, including the features new in 1965: 2048 words of memory, a Z register, an overflow flag, and an interrupt facility.
Block 45 held damaged data, and block 51 was identical to block 52.
LegalizeAdulthood
left a comment
LegalizeAdulthood
left a comment
There was a problem hiding this comment.
This looks good to me. I suggest that you squish all your commits down to a single commit to eliminate all the merges that are just updating your branch to master.
Can we add any sort of simh script test that would validate this functionality?
|
The ubuntu build failed with: I've also seen this failure on ubuntu; it's not caused by this change. |
|
I am not sure what I am supposed to do and how to accomplish it. And no, there are no test scripts for this particular functionality. |
|
I'll leave it up to the owners of the repository to decide if they want that done. Your PR can be merged into master without conflicts, which is the important part. |
|
I would appreciate if this can be merged as is - I have almost forgotten that this PR even exists. |
|
Unfortunately I don't have rights to do that -- if the repository owner would like to discuss with me how to merge this without merge commits (e.g. rebase first), I can help with that. Personally I prefer a linear history and no merge commits, but that is up to the repository owner. |
|
I'll work on merging it into the ZIMH fork. |
|
@pkoning2 I think this can be merged as well - sorry about the many merges. |
5 participants
An appropriate boot ROM is chosen based on the attached disk image.
Replaces the PR with same name and functionality but without the commit clutter.