Skip to content

Improve CI workflow for benchmarks#117

Merged
ggeier merged 4 commits into
open-s4c:mainfrom
mariaxarisi:ci
Jun 29, 2026
Merged

Improve CI workflow for benchmarks#117
ggeier merged 4 commits into
open-s4c:mainfrom
mariaxarisi:ci

Conversation

@mariaxarisi

Copy link
Copy Markdown
Contributor

This PR improves the reliability of the benchmarking pipeline by running direct branch comparisons and standardizing all tests to use hyperfine.

What Changed:

  • Checks out and builds both main and the current branch, running them sequentially on the exact same CI runner to eliminate hardware differences.
  • Added leveldb, raytracing, and scratchapixel to the CI matrix so they run in parallel, speeding up CI execution.
  • Switched the leveldb benchmark from a duration-based run (--duration=10) to a fixed workload (--reads=500000) and migrated it to use hyperfine.
  • Refactored the way results from hyperfine are parsed to correctly handle ms and s units.

@ggeier ggeier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement, good job 👍

@ggeier ggeier requested a review from db7 June 19, 2026 14:43
@ggeier

ggeier commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

@db7 we'll have to merge this one without the benchmark pipeline passing, because the measurement units changed.

@db7 db7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting fancy.

@ggeier

ggeier commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

@db7 is it not possible to merge because of the pipeline or did my resolving the merge conflict not work? Could you check if you can merge? Otherwise @mariaxarisi will need to rebase monday.

- Replaced artifact-based baseline comparison with a dual-checkout strategy.
- Checks out both `main` (baseline) and the current code, running them sequentially on the same GitHub Actions runner.

Signed-off-by: mariaxarisi <maria.charisi@huawei.com>
Signed-off-by: mariaxarisi <maria.charisi@huawei.com>
Signed-off-by: mariaxarisi <maria.charisi@huawei.com>
Signed-off-by: mariaxarisi <maria.charisi@huawei.com>
@ggeier ggeier merged commit 4990eb8 into open-s4c:main Jun 29, 2026
14 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants