Skip to content

feat: Detailed flag evaluation - #130

Merged
NeaguGeorgiana23 merged 42 commits into
mainfrom
detailed_evaluation
Aug 24, 2026
Merged

feat: Detailed flag evaluation#130
NeaguGeorgiana23 merged 42 commits into
mainfrom
detailed_evaluation

Conversation

@NeaguGeorgiana23

Copy link
Copy Markdown
Contributor

This PR

  • Implements detailed flag evaluation methods (GetBooleanDetails, GetStringDetails, GetIntegerDetails, GetDoubleDetails, GetObjectDetails) in the Features interface and ClientAPI class as mentioned in OpenFeature Specification Requirement 1.4.1.
  • Returns typed FlagEvaluationDetails<T> (BoolFlagEvaluationDetails, StringFlagEvaluationDetails, IntFlagEvaluationDetails, DoubleFlagEvaluationDetails, ObjectFlagEvaluationDetails) populating flag_key, value, reason, variant, flag_metadata, error_code, and error_message.
  • Updates Bazel BUILD dependencies for features, client_api, and client_api_test.
  • Adds unit tests in test/client_api_test.cpp verifying all detailed evaluation overloads, provider metadata and variant propagation, and error state handling.

Related Issues

Fixes #73

Notes

  • The detailed evaluation methods encapsulate provider resolution results along with invocation parameters into FlagEvaluationDetails<T> value objects while maintaining exception safety guarantees.

Follow-up Tasks

  • Implement the hook execution lifecycle pipeline (before, after, error, finally) inside ClientAPI::EvaluateFlag.

NeaguGeorgiana23 and others added 30 commits July 7, 2026 13:19
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23
NeaguGeorgiana23 requested review from a team as code owners August 11, 2026 07:57
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c2fee2ac-dfc8-4b70-8128-fb0422479517

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>
@NeaguGeorgiana23
NeaguGeorgiana23 merged commit 7865abe into main Aug 24, 2026
5 checks passed
NeaguGeorgiana23 pushed a commit that referenced this pull request Aug 24, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.4](v0.1.3...v0.1.4)
(2026-08-24)


### Features

* Detailed flag evaluation
([#130](#130))
([7865abe](7865abe))
* Hook support for client class
([#127](#127))
([72d4c91](72d4c91))
* Overload client functions
([#129](#129))
([3a1c4d4](3a1c4d4))
* Update global api
([#123](#123))
([a5cc90e](a5cc90e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Detailed Flag Evaluation

2 participants