Stabilize commons infrastructure for attack_surface_approximation compatibility#8
Draft
krpandrei05 wants to merge 4 commits into
Draft
Stabilize commons infrastructure for attack_surface_approximation compatibility#8krpandrei05 wants to merge 4 commits into
krpandrei05 wants to merge 4 commits into
Conversation
Converted filenames to absolute paths before passing them to Docker. This ensures correct bind-mounting and avoids 400 Bad Request errors on Linux hosts. Fixes: #7 Signed-off-by: Andrei Carp <andrei.krp@gmail.com>
Added replacements for Ghidra-specific types like undefined8, bool, and uint in the decompiled code. This prevents ParseError when pycparser processes the main function. Signed-off-by: Andrei Carp <andrei.krp@gmail.com>
…acts Implemented fallback to Entry Point in decompile_function.py when 'main' is missing. Updated ghidra.py with a robust regex to strip all C-style comments and a cleaner for Ghidra-specific artifacts (processEntry, PTR_FUN_, stack references) to ensure compatibility with pycparser. Fixes: #9 Signed-off-by: Andrei Carp <andrei.krp@gmail.com>
krpandrei05
force-pushed
the
krpandrei/fix/attack-surface-approximation-support
branch
from
111731a to
20b423d
Compare
Updated pyproject.toml to use a fixed Python version (3.12.7) and ensured all core dependencies are pinned to exact versions for consistency across the CRS environment. Signed-off-by: Andrei Carp <andrei.krp@gmail.com>
razvand
requested changes
May 18, 2026
razvand
left a comment
razvand
left a comment
Contributor
There was a problem hiding this comment.
Use a blank line between Fixes and the Signed-off-by message.
Limit commit messages to 72 characters.
Start commit title with capital, i.e. instead of support stripped binaries ..., use Support stripped binaries ...
Use Python instead of python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted filenames to absolute paths before passing them to Docker. This ensures correct bind-mounting and avoids 400 Bad Request errors on Linux hosts.
Fixes: #7, Fixes: #9