Skip to content

chore: Update major deps + build tool - #494

Open
alexbass01 wants to merge 12 commits into
open-component-model:masterfrom
alexbass01:update-deps
Open

chore: Update major deps + build tool#494
alexbass01 wants to merge 12 commits into
open-component-model:masterfrom
alexbass01:update-deps

Conversation

@alexbass01

Copy link
Copy Markdown
Member

What this PR does / why we need it:

  • Updates major libaries such as React or Mui to newest version
  • Replaces the old create react app build tool with vite as that seems to have been the major cause of SAST vulns
  • Re-arranges Dockerfile for better caching

It's a big pr, so I think manual testing would be best option. I tested locally as much as I know, but surely did not catch all paths and options. Let's do a test walkthrough together.

Also if you are curious, take a look at _Migration.md but needs to be deleted before merge.

Which issue(s) this PR fixes:
Fixes #491

Special notes for your reviewer:

Release note:


js-yaml v5 is a rewrite with flat named exports and no default export,
so 'import yaml from "js-yaml"' breaks at runtime. Switch to a namespace
import, which works with both v4 (CJS) and v5, unblocking renovate
PR open-component-model#487. yaml.dump output was verified to be byte-identical to v4 for
typical payloads (only whitespace-only strings are quoted differently).

Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Triage of the renovate Dependency Dashboard (open-component-model#486): disable these major
updates via documented packageRules so renovate stops proposing them and
autocloses the premature PRs (open-component-model#483, open-component-model#488, open-component-model#490), while minors keep flowing:

- eslint 10: blocked upstream (eslint-plugin-jsx-a11y caps eslint at ^9
  and appears abandoned; eslint-plugin-react caps at ^9.7)
- react/react-dom 19: blocked by deprecated react-beautiful-dnd
  (src/landing.js, src/util/versionOverview.js); tracked in open-component-model#289
- react-router 8: peer deps require react >= 19.2.7, hence transitively
  blocked by the React 19 migration (open-component-model#289)
- @mui/* 9: 2-4 majors behind with ~188 import sites and no tests;
  needs a dedicated migration (codemods + manual click-through)

Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
…ilities

react-scripts@5.0.1 pins dozens of vulnerable transitive deps (webpack 4,
old postcss, nth-check, svgo, serialize-javascript, etc.) that npm audit
cannot fix without breaking CRA. Replacing it with Vite drops the package
count from ~1627 to ~444 with 0 vulnerabilities.

Changes:
- Add vite@^6.3.5 + @vitejs/plugin-react@^4.5.2 as devDependencies
- Add vite.config.js with esbuild.loader:jsx to handle .js files with JSX
- Move index.html from public/ to project root (Vite entry point)
- Rename REACT_APP_* env vars to VITE_* in .env files and 5 source files
  (process.env.REACT_APP_* -> import.meta.env.VITE_*)
- Keep window.REACT_APP_DELIVERY_SERVICE_API_URL in api.js (runtime injection)
- Add dist/ to .gitignore and eslint ignores (Vite outputs there, not build/)
- Remove stale eslint-disable-next-line no-undef comments (no longer needed)

Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
… .js files

Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
…REACT_APP_BUILD_VERSION)

Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
Signed-off-by: Alexander Bassmanow (AlexBass01) <alexander.bassmanow@sap.com>
@alexbass01
alexbass01 requested a review from a team as a code owner September 7, 2026 12:42
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: fffdf4bb-fe5c-41f8-afd0-5a62f5ec9839


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread _Migration.md
@@ -0,0 +1,134 @@
# Dependency migration notes — DELETE BEFORE MERGE

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete before Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update major dependencies for odg-ui

1 participant