Ensure consistent JWK generation. - #45
Conversation
Added a few debugging logs as well.
|
@onur looks like some of the tests on Linux are having issues:
It looks like the same exact test failures took place on the last two commits on master (also only for Linux), so the failures were not introduced by this PR. How would you like to proceed with this? |
|
Hey @onur. That sounds fine to me. That's great too, because then it would be possible to easily implement an async version of this using reqwest's Keep me posted. I'm happy to rebase or make any other updates as needed. |
|
Awww man, just debugged the same issue, and wanted to submit basically the same PR. Can we get this merged? |
|
@axos88 yea, this was a pesky issue to debug. |
|
I am attempting to upgrade this client to ACMEv02 (in a fork, since this appears to be abandoned). |
I'm opening this PR because I was running into issues where the HTTP-01 workflow was failing due to invalid signatures and such. I investigated the code here after thoroughly reviewing my own code in the service which is using this crate. The issue has been resolved after using BTreeMap instead of standard HashMap.
It was one of those tough bugs to resolve where the issue was presenting itself intermittently. Sometimes the workflow would succeed, other times it would fail for no apparently reason or code change on my side.
After making this update, the issue has not presented itself. For reasoning straight from the docs, see the first few paragraphs under this heading: https://doc.rust-lang.org/std/collections/index.html#iterators