feat: extend spec.versionUpgrade to support kubernetes and stack upgrade types#19
Merged
Merged
Conversation
…ade types spec.versionUpgrade=true now derives the UpgradePolicy type from which version fields are set: talosVersion only -> UpgradeTypeTalos (existing), kubernetesVersion only -> UpgradeTypeKubernetes, both -> UpgradeTypeStack. Updates spec.kubernetesVersion and spec.versionUpgrade field comments to document the three-way type derivation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.versionUpgrade=truenow derives UpgradePolicy type from which version fields are set:talosVersiononly →UpgradeTypeTalos,kubernetesVersiononly →UpgradeTypeKubernetes, both →UpgradeTypeStackspec.kubernetesVersionfield comment: removes "Informational" label, documents three-way type derivationspec.versionUpgradecomment to document the three casesCompanion PR
platform#27 --
reconcileVersionUpgradetype-aware implementation + 2 new unit testsTest plan
TestTalosCluster_VersionUpgrade_KubernetesOnly_CreatesKubePolicy(platform unit)TestTalosCluster_VersionUpgrade_Stack_CreatesBothVersions(platform unit)make testin platform)