Skip to content

fix(server): coordinate session creation lifecycle - #383

Merged
NWYLZW merged 1 commit into
mainfrom
codex/fix-session-creation-race
Aug 18, 2026
Merged

fix(server): coordinate session creation lifecycle#383
NWYLZW merged 1 commit into
mainfrom
codex/fix-session-creation-race

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make HTTP session creation the only database writer while early WebSocket connections wait for the completed creation lifecycle
  • reject adapter startup for missing sessions and avoid attaching sockets that close during startup
  • share cancellation state across overlapping creation attempts and add regression coverage for races, failures, timeouts, and termination

Changelog

  • Changelog path or "Not applicable": changelog/1.0.0-rc.4/server.md

Screenshots

Not applicable

Validation

  • pnpm exec vitest run apps/server/__tests__/services/session-creation-lifecycle.spec.ts apps/server/__tests__/websocket/server.spec.ts apps/server/__tests__/websocket/connection-loading.spec.ts apps/server/__tests__/websocket/lazy-connection.spec.ts apps/server/__tests__/services/session-start.spec.ts apps/server/__tests__/services/session-create.spec.ts apps/server/__tests__/routes/sessions.spec.ts apps/server/__tests__/services/channel-resume.spec.ts (141 tests passed)
  • pnpm typecheck
  • pnpm exec eslint for the changed server source and tests
  • git diff --check

Review Scope

  • Risk: medium
  • Applicable profiles: server session creation and WebSocket lifecycle
  • Evidence: lifecycle, WebSocket lazy-loading, session start/create, route, and channel-resume regression tests; full typecheck; scoped lint
  • Rule exceptions: none

Experience Review

  • 已判断是否需要沉淀经验
  • 如需要,已运行 $post-task-experience-review
  • reviewer PASS / NOT APPLICABLE 后才进入 merge

Policy Conflict Review

  • Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS

@NWYLZW
NWYLZW requested a review from a team as a code owner August 18, 2026 16:07
@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oneworks-dev Ready Ready Preview Aug 18, 2026 4:09pm

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience Review

Before merge, make sure the PR body contains this completed checklist:

## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer `PASS` / `NOT APPLICABLE` 后才进入 merge

Checklist to confirm:

  • Decide whether this PR produced reusable project experience.
  • If experience should be captured, run $post-task-experience-review.
  • Merge only after the independent reviewer reports PASS or NOT APPLICABLE for the Experience Review Result.
  • For workflow, permission, or release-rule documentation changes, also add this checked section to the PR body after an independent read-only conflict review:
## Policy Conflict Review
- [x] Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS

@NWYLZW
NWYLZW merged commit d33fc76 into main Aug 18, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant