Skip to content

ONEKEY baseline#79

Draft
qkaiser wants to merge 4 commits into
mainfrom
onekey-baseline
Draft

ONEKEY baseline#79
qkaiser wants to merge 4 commits into
mainfrom
onekey-baseline

Conversation

@qkaiser

@qkaiser qkaiser commented May 13, 2023

Copy link
Copy Markdown
Contributor

Draft branch to establish a baseline for code quality and probably do some refactoring as mentioned in #75

@qkaiser qkaiser self-assigned this May 13, 2023
@qkaiser qkaiser marked this pull request as draft May 13, 2023 12:17
@tnias

tnias commented Jun 19, 2023

Copy link
Copy Markdown

Not sure if this is the correct place to comment on this, but this looks like a cleanup and I thought it might fit. :)

The pyproject.toml (or the setup.py before) is very vague with license = "GNU GPL".

I found the following indicators:

  • LICENSE file is GPL-3.0
  • ubireader/ubi/defines.py: GPL-2.0-or-later
  • ubireader/ubifs/defines.py: GPL-2.0 (without clarification for "-only" or "-or-later")
  • all other non-empty python files had a GPL-3.0-or-later header

@qkaiser

qkaiser commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

@tnias makes sense, thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants