Skip to content

Add leeway to token verification#73

Merged
kukovecz merged 3 commits into
masterfrom
token-verify-leeway
Jun 10, 2026
Merged

Add leeway to token verification#73
kukovecz merged 3 commits into
masterfrom
token-verify-leeway

Conversation

@kukovecz

@kukovecz kukovecz commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kukovecz kukovecz requested a review from vlaci June 8, 2026 14:54
Using this leeway, the `now` parameter is not needed anymore, as the
sub-1 second is calculated into the leeway.

From the documentation, the leeway is:
"Implementers MAY provide for some small leeway, usually no more than
a few minutes, to account for clock skew"
@kukovecz kukovecz marked this pull request as draft June 8, 2026 15:28
@kukovecz kukovecz force-pushed the token-verify-leeway branch 2 times, most recently from 976a979 to 9f0c1bf Compare June 8, 2026 17:39
@kukovecz kukovecz marked this pull request as ready for review June 8, 2026 17:43
Comment thread onekey_client/client.py Outdated
@kukovecz kukovecz force-pushed the token-verify-leeway branch from 9f0c1bf to df22c3e Compare June 9, 2026 12:54
@kukovecz kukovecz added this pull request to the merge queue Jun 10, 2026
Merged via the queue into master with commit 5b339d2 Jun 10, 2026
2 checks passed
@kukovecz kukovecz deleted the token-verify-leeway branch June 10, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants