Skip to content

ap-8349 # add formsAppId column and filter to Form Store table#1046

Draft
Zaxist wants to merge 3 commits intomasterfrom
ap-8349
Draft

ap-8349 # add formsAppId column and filter to Form Store table#1046
Zaxist wants to merge 3 commits intomasterfrom
ap-8349

Conversation

@Zaxist
Copy link
Copy Markdown
Contributor

@Zaxist Zaxist commented May 6, 2026

Summary

Adds a formsAppId column and multi-select filter to the Form Store table, allowing users to filter submissions by the app used to submit the form.

  • New "App" column displays the formsAppId (or "No App" for appless submissions)
  • Multi-select filter supports filtering by multiple app IDs and/or appless submissions simultaneously
  • Filter options are derived from form.formsAppIds plus a "No App" option for null
  • App names are not resolved yet — just showing raw IDs for now

Depends on API support from https://github.com/oneblink/product-api/pull/1623


Requester Checklist

Please only check the items that you have actioned. Do not check items that are not applicable to your PR.

Implementation

  • Have you tested your implementation locally?
  • If applicable, has an appropriate changelog entry been added? Do not include if you are fixing/changing something that is only in the current release.
  • There are no warnings that have been suppressed unnecessarily
  • Have automated tests been added, or have related ones been updated to cover the change?
  • Have all OneBlink dependency updates been completed (eg apps / apps-react / types etc).
  • Have you ensured this change does not add unwanted dependencies?
  • If this PR contains a refactor, have relevant Jira testing tasks added?
  • Changes that will knowingly make the feature/bug incomplete have been commented with TODO and a description of what needs to be done to finish the feature/bug
  • Any changes made to public APIs have been reflected in the documentation
  • Have you isolated business logic where possible to allow for unit testing?

Logging and Debugging

  • Are the error messages, if any, informative?
  • Are there enough log events and are they written in a way that allows for easy debugging?
  • "Debugging" code removed
  • Front-end: No erroneous Console.WriteLines

Readability

  • All class, variable, property and method modifiers are provided with the smallest scope possible
  • New files, variables and functions are descriptive/comprehensible and named consistently.
  • There is no dead code (unreachable code)
  • There is no usage of magic numbers
  • There is no commented out code.
  • In hard-to-understand areas, comments exist and describe rationale or reasons for decisions in code

Security

  • All personal data inputs are checked (for the correct type, length/size, format, and range).
  • No sensitive information is logged or visible in a stacktrace
  • Are authorization and authentication handled correctly?
  • Is (user) input validated, sanitized, and escaped to prevent security attacks such as cross-site scripting or SQL injection?
  • Is data retrieved from external APIs or libraries checked for security issues?
  • Do API endpoints return appropriate status codes

Reviewer Guide

  • It is important that you understand the purpose of the PR.
  • You are encouraged to engage with the requestor if you do not understand any of the proposed code changes/additions/deletions.
  • Do you, the reviewer, understand what the code does? Do you think a specific expert, like a security expert or a usability expert, should look over the code before it can be accepted?
  • Is a framework, API, library, or service used that should not be used? Are there alternatives you could recommend?
  • Are there existing hooks/components/functions in the same code base that could be utilised?
  • When reviewing tests, attempt to identify missing edge cases that may be relevant to the proposed implementation
  • Ensure you check for:
    • Security
    • Scalability
    • Performance
    • Maintainability

Zaxist and others added 3 commits May 6, 2026 15:52
Allows users to filter submissions by the app used to submit.
Supports multi-select with nullable values for appless submissions.

Co-authored-by: Cursor <cursoragent@cursor.com>
The column and filter only appear when getFormsAppLabel is provided
to OneBlinkFormStoreProvider. The consumer controls label resolution.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant