Skip to content

Improve this repository's automated test coverage with real code chan...#31

Draft
kivo360 wants to merge 1 commit into
mainfrom
mozart/a7b47760
Draft

Improve this repository's automated test coverage with real code chan...#31
kivo360 wants to merge 1 commit into
mainfrom
mozart/a7b47760

Conversation

@kivo360

@kivo360 kivo360 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Automated change by a Mozart background run.

Task

Improve this repository's automated test coverage with real code changes across multiple files. Steps: (1) explore the packages/ directory and pick 2 or 3 important source modules that currently lack dedicated unit tests (skip generated code and type-only files). (2) Study the existing test conventions (package.json scripts, existing test files) and write thorough unit tests for the modules you picked, covering edge cases and error paths. (3) If a new test exposes a genuine bug in a source module, fix the module. (4) Run the tests you added — scope the test command to the packages you touched, NOT the whole monorepo — and iterate until they pass. Hard requirements: at least 3 new test files spanning at least 2 different packages; do not reformat or refactor unrelated code; do not change README or docs.

Run e1909d90-a02e-4747-8f59-69abb1ef189d · session a7b47760-2115-4dc6-9062-1e8102ccbb73

@kivo360 kivo360 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and verified locally (checked out refs/pull/31/head).

Verdict: safe to merge — pure test coverage, no source changes.

  • packages/sdk/test/history.test.ts (new, 221 lines) covers eventRowToStreamEvent/eventRowsToStreamEvents with real narrowing helpers rather than casts — token/reasoning/tool_call union shapes, null rows, ordering.
  • Also adds acp-client/test/acp-crossws.test.ts + ws-transport.test.ts.
  • Ran vitest run test/history.test.ts22/22 pass. No files under src/ touched, so zero regression surface.

Recommend merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant