fix: don't inject attributes into TypeScript generics - #1
Merged
Conversation
The JSX regex was matching `<` in TypeScript generics like `Accessor<boolean>`, `createContext<Type>`, and `createStore<Store>` as if they were JSX opening tags. Add a negative lookbehind `(?<!\w)` so the `<` must NOT be preceded by a word character. In JSX, `<` follows whitespace/operators/punctuation, but in generics it follows an identifier. Fixes parse errors when used with real-world SolidJS apps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<in TypeScript generics (Accessor<boolean>,createContext<Type>,createStore<Store>) as JSX opening tags, injectingdata-solid-sourceattributes inside type annotations and causing parse errors(?<!\w)to the regex — JSX<is preceded by whitespace/operators, generics<is preceded by an identifier characterTest plan
bun run devno longer throws parse errors🤖 Generated with Claude Code