feat: redesign runner list controls and add collapsible groups - #78
Open
fortrel wants to merge 5 commits into
Open
feat: redesign runner list controls and add collapsible groups#78fortrel wants to merge 5 commits into
fortrel wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR updates Swift build and app-bundle executable paths, adds ignored build and VS Code artifacts, introduces collapsible runner groups and dismissible update prompts, and replaces runner-row chip layout with a wrapping custom ChangesMenubar and build updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefile'srunandapptargets, which referenced stale binary paths/names (.build/debug/MacRunnerand.build/release/MacRunner) that no longer matched the package's actual product name (mac-runner) orswift build's multi-arch output location, and were failing for local development builds.Test plan
swift buildsucceedsswift test— 105/105 tests passmake appbuilds a working.appbundleImageRenderersnapshots (no Screen Recording/Accessibility permission available in this environment to drive the live popover)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
UI Improvements