Skip to content

fix: improve org runner reauth UX - #76

Merged
Peyton-Spencer merged 1 commit into
mainfrom
codex/improve-org-runner-reauth-ux
Jul 1, 2026
Merged

fix: improve org runner reauth UX#76
Peyton-Spencer merged 1 commit into
mainfrom
codex/improve-org-runner-reauth-ux

Conversation

@Peyton-Spencer

@Peyton-Spencer Peyton-Spencer commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • detect org-runner registration failures that need the admin:org scope and append the exact gh auth refresh -h github.com -s admin:org recovery command
  • add Add Runner dialog recovery controls to copy the command, copy the full error, and launch gh auth refresh ... --clipboard so the device flow opens with the code copied
  • add coverage for the admin:org recovery message

Validation

  • git diff --check
  • swift test (fails before tests run on existing Swift 6/macOS build issues: Containerization actor diagnostics in RunnerManager.swift and missing PreviewsMacros for #Preview in MenuBarView.swift)
  • swift test --filter MacRunnerTests/testRegistrationTokenFailureAddsAdminOrgRecoveryCommand (same package build failures before the filtered test can execute)

Live runner cleanup performed

  • Refreshed local gh auth to include admin:org
  • Added org-level runner mac-runner-4584 for ditto-assistant; verified online via GitHub API
  • Removed old repo-level runners from ditto-assistant/backend and ditto-assistant/ditto-app; both repo runner endpoints now report total_count: 0
  • Cleared stale local Mac Runner config/directories, leaving only the org runner directory

Summary by CodeRabbit

  • New Features

    • Added clearer recovery guidance when runner registration fails due to missing GitHub admin-org permissions.
    • Added an in-app option to copy the suggested command and open a reauthorization flow directly from the error view.
  • Bug Fixes

    • Improved error messages to better explain permission-related failures instead of showing only raw command output.
    • Enhanced the runner setup screen to reset recovery status when retrying actions.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Peyton-Spencer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3c12d99-77c6-47ab-9400-0a99596b7349

📥 Commits

Reviewing files that changed from the base of the PR and between fa87769 and dd4d969.

📒 Files selected for processing (3)
  • Sources/Services/GHCLIService.swift
  • Sources/Views/AddRunnerView.swift
  • Tests/MacRunnerTests/MacRunnerTests.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-org-runner-reauth-ux

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Peyton-Spencer
Peyton-Spencer merged commit 3facef1 into main Jul 1, 2026
1 of 2 checks passed
@Peyton-Spencer
Peyton-Spencer deleted the codex/improve-org-runner-reauth-ux branch July 1, 2026 16:10
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
## [1.17.3](v1.17.2...v1.17.3) (2026-07-01)

### Bug Fixes

* improve org runner reauth UX ([#76](#76)) ([3facef1](3facef1))
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.17.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant