Fix settings pane scrolling

[Peyton-Spencer]

Summary

• Wrap the General, GitHub, and About settings tabs in independent scroll views so controls remain reachable when the settings window is small.
• Increase the settings window minimum height from 300 to 420.
• Keep the About tab vertically centered when there is extra space while still allowing it to scroll when constrained.

Verification

• Not run: swift test is unavailable in this Linux container because swift is not installed.

Summary by CodeRabbit

• UI Improvements
  • Enhanced scrollability across settings tabs (General and GitHub) by wrapping tab content in scroll containers.
  • Updated the About tab layout to better fit available space while remaining scrollable.
  • Increased the overall settings window minimum height for improved sizing and readability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: abd8414b-81f7-4fa7-a1d5-bf275caf8d83

📥 Commits

Reviewing files that changed from the base of the PR and between 5f33c25 and bcc1ac1.

📒 Files selected for processing (1)

• Sources/MacRunner/MacRunnerApp.swift

---

📝 Walkthrough

Walkthrough

SettingsView tab layouts in MenuBarView.swift are reworked to improve scrollability: General and GitHub tabs replace non-scrolling VStack+Spacer containers with ScrollView wrappers; the About tab replaces a plain VStack with a GeometryReader-backed ScrollView using the proxy height for framing. The TabView minimum height is raised to 420, and MacRunnerApp increases the Settings window size from 400×300 to 400×420.

Changes

Settings window scrollability and sizing

Layer / File(s)	Summary
Tab contents wrapped in ScrollView Sources/Views/MenuBarView.swift	General tab removes trailing Spacer() and wraps content in a ScrollView; GitHub tab wraps its auth UI in a ScrollView; About tab is rewritten with GeometryReader containing a ScrollView, using the proxy height as minHeight for the inner frame.
TabView minimum height increase Sources/Views/MenuBarView.swift	.frame(minWidth: 400, minHeight: 420) replaces the previous smaller minimum height on the TabView, matching the new scrollable tab layout.
Settings window size update Sources/MacRunner/MacRunnerApp.swift	window.setContentSize in handleOpenSettings changes from 400×300 to 400×420, aligning the window dimensions with the updated TabView minimum frame.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐇 Hop, hop, the settings now scroll and flow,
No more Spacers wedged in a row,
GeometryReader knows just how tall,
ScrollView catches content before the fall,
Four-twenty pixels, the window stands proud —
This bunny approves, hopping out loud! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix settings pane scrolling' directly and clearly summarizes the main change in the pull request, which focuses on addressing scrolling issues in the settings pane through scroll view implementation and layout adjustments.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/settings-pane-scroll

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Sources/Views/MenuBarView.swift`:
- Line 628: The TabView's frame modifier specifies minHeight: 420, but the
window created with setContentSize uses NSSize(width: 400, height: 300), where
the height of 300 is less than the required minimum. Update the setContentSize
call to set the height to 420 to match the TabView's minimum height requirement
and prevent layout constraint conflicts when the view tries to expand to its
minimum required dimensions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2a78b579-1aa3-4000-94cd-9cd552924d2e

📥 Commits

Reviewing files that changed from the base of the PR and between 2b44e5d and 5f33c25.

📒 Files selected for processing (1)

• Sources/Views/MenuBarView.swift

[github-actions]

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀