Skip to content

feat(rules-nlp): add no-future-promises rule - #22

Merged
Peyton-Spencer merged 2 commits into
mainfrom
ocp/no-future-promises
May 11, 2026
Merged

feat(rules-nlp): add no-future-promises rule#22
Peyton-Spencer merged 2 commits into
mainfrom
ocp/no-future-promises

Conversation

@Peyton-Spencer

Copy link
Copy Markdown
Contributor

Summary

  • Adds the no-future-promises NLP rule for future-tense promise phrases like will help you, will enable, and will transform.
  • Wires the rule into the NLP registry, public exports, README tables, and focused rule tests.
  • Keeps the phrase list configurable through the phrases option for teams that want different promise patterns.

Closes #15.

Validation

  • bunx pnpm@9.15.9 --workspace-concurrency=1 build
  • bunx pnpm@9.15.9 --filter @faircopy/rules-nlp test
  • bunx pnpm@9.15.9 --workspace-concurrency=1 test
  • bunx pnpm@9.15.9 --workspace-concurrency=1 typecheck

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@Peyton-Spencer Peyton-Spencer left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-author review on head 249a667d12ad2027522221f69d4e84ade3000966.

No blocking findings. The rule mirrors the existing phrase-list pattern cleanly: configurable defaults, escaped whitespace-tolerant matching, sorted diagnostics, registry/export wiring, README coverage, and focused tests for defaults, custom override, mid-sentence matching, and registry exposure.

Verified locally with:

  • bunx pnpm@9.15.9 --filter @faircopy/rules-nlp test

Co-Authored-By: Codex <noreply@openai.com>

@Peyton-Spencer Peyton-Spencer left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-author review on updated head 34e401ea94609e414aceb327c6ef14d668689652.

No blocking findings. I also resolved the additive conflict from PR #21 landing first by merging current origin/main into this branch and keeping both no-jargon and no-future-promises wiring/tests.

Verified after the merge update:

  • bunx pnpm@9.15.9 --filter @faircopy/rules-nlp test
  • GitHub CI: pass
  • Merge state: CLEAN

@Peyton-Spencer
Peyton-Spencer merged commit c8a2550 into main May 11, 2026
1 check passed
@Peyton-Spencer
Peyton-Spencer deleted the ocp/no-future-promises branch May 11, 2026 00:25
github-actions Bot pushed a commit that referenced this pull request May 11, 2026
# [1.13.0](v1.12.0...v1.13.0) (2026-05-11)

### Features

* **rules-nlp:** add no-future-promises rule ([#22](#22)) ([c8a2550](c8a2550))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add no-future-promises rule

1 participant