feat(rules-nlp): add no-future-promises rule - #22
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Peyton-Spencer
left a comment
There was a problem hiding this comment.
Non-author review on head 249a667d12ad2027522221f69d4e84ade3000966.
No blocking findings. The rule mirrors the existing phrase-list pattern cleanly: configurable defaults, escaped whitespace-tolerant matching, sorted diagnostics, registry/export wiring, README coverage, and focused tests for defaults, custom override, mid-sentence matching, and registry exposure.
Verified locally with:
bunx pnpm@9.15.9 --filter @faircopy/rules-nlp test
Co-Authored-By: Codex <noreply@openai.com>
Peyton-Spencer
left a comment
There was a problem hiding this comment.
Non-author review on updated head 34e401ea94609e414aceb327c6ef14d668689652.
No blocking findings. I also resolved the additive conflict from PR #21 landing first by merging current origin/main into this branch and keeping both no-jargon and no-future-promises wiring/tests.
Verified after the merge update:
bunx pnpm@9.15.9 --filter @faircopy/rules-nlp test- GitHub CI: pass
- Merge state:
CLEAN
# [1.13.0](v1.12.0...v1.13.0) (2026-05-11) ### Features * **rules-nlp:** add no-future-promises rule ([#22](#22)) ([c8a2550](c8a2550))
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
no-future-promisesNLP rule for future-tense promise phrases likewill help you,will enable, andwill transform.phrasesoption for teams that want different promise patterns.Closes #15.
Validation
bunx pnpm@9.15.9 --workspace-concurrency=1 buildbunx pnpm@9.15.9 --filter @faircopy/rules-nlp testbunx pnpm@9.15.9 --workspace-concurrency=1 testbunx pnpm@9.15.9 --workspace-concurrency=1 typecheck