Skip to content

Add sqlfluff linter tests and diagnostics handling#51

Open
pabo99 wants to merge 12 commits into
omegaup:mainfrom
pabo99:sqlfluff-native-linter-clean
Open

Add sqlfluff linter tests and diagnostics handling#51
pabo99 wants to merge 12 commits into
omegaup:mainfrom
pabo99:sqlfluff-native-linter-clean

Conversation

@pabo99

@pabo99 pabo99 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Add native SQL linting support with sqlfluff in hook_tools.

Changes

  • Add SqlFluffLinter integration to the lint pipeline.
  • Add SQL unit tests for fix and lint-error flows.
  • Document SQL linter options in README (dialect, config, exclude_rules, templater).

Notes

  • Tests are mocked to validate hook_tools integration behavior.
  • Goal: run SQL validation/fixes natively in the existing pipeline (no shell workaround).

Comment thread .github/workflows/ci.yml
python -m pip install --upgrade pip
python -m pip install pylint pep8

- name: Run unit tests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

los tests de la linea 19 ya deberian de correr los tests que estas agregando, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí, los de la línea 19 ya deberían cubrir esos tests vía pytest.

Si consideras que este paso adicional no es necesario, lo podemos quitar. Solo que perderíamos la señal explícita de compatibilidad en la matriz de Python (3.11 y 3.13) para esos casos puntuales, y también una falla más acotada/fácil de diagnosticar cuando se rompe específicamente el lint de SQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants