Add pre-commit hook for yaml formatting - #197
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces pre-commit automation for YAML formatting (and secret scanning) and applies the resulting formatting changes across the repository’s YAML configuration and Ansible playbooks.
Changes:
- Add
yamlfmt(andgitleaks) to.pre-commit-config.yaml. - Reformat Ansible playbooks under
env/to remove extraneous blank lines/whitespace. - Reformat various repo configuration YAMLs (GitHub workflows, Codecov, spellcheck config) for consistent indentation and spacing.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
env/vagrant.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/runtime.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/runtime-deps.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/kmod.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/docker.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/dev.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/ci.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
env/build-dep.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
core/kmod/.clang-format |
Whitespace cleanup in the kernel-module clang-format config header. |
.spellcheck.yml |
YAML reindent/format of spelling configuration. |
.pre-commit-config.yaml |
Adds gitleaks and yamlfmt pre-commit hooks. |
.github/workflows/stale.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
.github/workflows/push.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
.github/workflows/pull-request.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
.github/workflows/main.yml |
YAML formatting cleanup + minor inline comment spacing normalization. |
.github/dependabot.yml |
YAML formatting cleanup (blank-line/whitespace normalization). |
.codecov.yml |
YAML formatting cleanup (comment spacing/blank-line normalization). |
.clang-format |
YAML formatting cleanup (whitespace/indentation normalization). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.pre-commit-config.yaml:7
- The PR title indicates this change is about YAML formatting, but this file also adds a new
gitleakssecret-scanning hook. That extra scope can be surprising because it can introduce new CI/pre-commit failures unrelated to formatting.
Consider either updating the PR title/description to mention the new secret-scanning hook, or moving the gitleaks addition to a separate PR so the formatting change can be reviewed/rolled out independently.
repos:
- repo: https://github.com/gitleaks/gitleaks
rev: v8.30.1
hooks:
- id: gitleaks
No description provided.