Restore the cursor on SIGTERM - #9
Merged
Merged
Conversation
The default SIGTERM action exits immediately, bypassing terminal teardown and leaving an interactive cursor hidden. Install a handler only when stdout is a tty, carry the signal through the normal run-loop exit, and return the conventional 143 status after restoring the cursor. Redirected output keeps the default signal behavior and receives no teardown bytes. Add a pty-driven regression covering both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the cursor when interactive
ttfxreceives SIGTERM and exits with status 143. Redirected output keeps the default SIGTERM behavior.<<< AI wording below >>>>
Problem
SIGTERM normally exits immediately, bypassing terminal teardown and leaving the cursor hidden when
ttfxis writing to a terminal.Fix
Install a SIGTERM handler only when stdout is a tty, carry the signal through the normal run-loop cleanup, and return the conventional
128 + SIGTERMstatus (143). When stdout is redirected, keep the default signal action so the stream is not given extra teardown bytes.Verification