Keep editor content out of the footer - #43
Open
kevinherron wants to merge 1 commit into
Open
Conversation
Give the status controls their own theme-colored surface and end the clipped editor viewport at its top edge so document content cannot render behind the footer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer controls and status text currently float over the editor. At some text sizes, document text and the caret remain visible underneath, causing the footer and document content to overlap.
This gives the full-width footer an opaque surface using the active theme background and clips the editor viewport exactly at the footer's top edge. The footer retains a minimum height so its fixed-size controls remain inside the opaque region at the smallest supported desktop text scale.
The save and open controls, status display, word count, theme behavior, text scaling, and search overlay remain unchanged.
Before
After