Add macOS app icon to the Qt bundle - #31
Open
crueber wants to merge 1 commit into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the qmake build produces an
omawrite.appbundle, but unlike Linux (where the SVG is wired into icon themes) the bundle had no icon, so it showed macOS's generic executable icon in the Dock and Finder.This adds
pkgbuild/omawrite.icns(generated from the existingpkgbuild/omawrite.svgat 16–1024px, including @2x variants) and wires it in for macOS builds only:macx { ICON = pkgbuild/omawrite.icns }Linux builds are unaffected — the
.prochange is scoped tomacxand the icns is only referenced there. Suggested downstream: Homebrew packaging currently regenerates this at build time; having it upstream lets packagers ship the bundle as-is.