Recover screen-recording indicator after stuck probes - #9296
Open
fresh3nough wants to merge 1 commit into
Open
Conversation
refresh() skipped work while statusProc.running was true. If onExited never fired after an abrupt gpu-screen-recorder death, the Process stayed "running" forever and the bar icon froze on the last state. Watchdog-clear stuck probes and poll every 2s so abnormal kills are noticed without a shell restart. Fixes omacom#9205 Signed-off-by: fresh3nough <anonwurcod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9205.
ScreenRecording.qmlpolls with a one-shotProcess(pgrep).refresh()returns early whilestatusProc.runningis true. IfonExitednever fires cleanly (abrupt recorder kill, handler glitch, etc.), that flag stays true forever — no further probes run and the bar icon freezes on "recording" even when nogpu-screen-recorderprocess exists. Workaround wasomarchy restart shell.Change
running, forcestatusProc.running = falseand refresh again.omarchy-capture-screenrecording's indicator toggle still update the bar.Test plan
screenrecording-test.shstill passes