Stop planting an unparseable default keyring stub - #9289
Open
fresh3nough wants to merge 1 commit into
Open
Conversation
default-keyring.sh wrote a plaintext ini-style Default_keyring.keyring that gnome-keyring 50.x cannot parse. On login the daemon abandons it and creates an empty Default_keyring_N.keyring, wiping Chrome Safe Storage and Docker credentials every session. Seed only the directory and default pointer; quarantine existing stubs via migration. Fixes omacom#9235 Signed-off-by: fresh3nough <anonwurcod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9235.
install/user/default-keyring.sh(and the quattro upgrade path) hand-wrote~/.local/share/keyrings/Default_keyring.keyringas a plaintext ini stub:gnome-keyring50.x cannot parse that format. On every login it logskeyring was in an invalid or unrecognized format, abandons the path, and creates a fresh emptyDefault_keyring_N.keyring. Secrets stored in the previous session (Chrome Safe Storage, Docker credential helper, etc.) are gone.Change
defaultpointer; let the daemon create a native keyring on first use.omarchy-upgrade-to-quattro.1788139500.shquarantines existing plaintext stubs (keeps real binary keyrings) and ensures the default pointer exists.Test plan
Default_keyring.keyringdefaultpointeromarchy-invalid-stub-backup/./test/shell.d/default-keyring-test.shpasses