Fall back selection to color8 when alacritty has no selection block - #9275
Open
fresh3nough wants to merge 1 commit into
Open
Fall back selection to color8 when alacritty has no selection block#9275fresh3nough wants to merge 1 commit into
fresh3nough wants to merge 1 commit into
Conversation
Themes installed without colors.toml and without [colors.selection] were
getting selection == foreground from omarchy-theme-colors-from-alacritty,
which locked every {{ selection }} consumer into invisible text-on-text
highlights. Use the same muted cascade as omarchy-theme-color.
Fixes omacom#9266
Signed-off-by: fresh3nough <anonwurcod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9266.
omarchy-theme-colors-from-alacrittyfell back to$foregroundwhen a theme had no[colors.selection]block. That value was written intocolors.tomlasselection, which then beatomarchy-theme-color's own cascade (selection->selection_background->color8->color0->background). Neovim Visual/LSP highlights, gum prompts, and btop selected rows all rendered as invisible text-on-text.Change
Use the same muted cascade
omarchy-theme-coloralready uses:selection_background=${selection_background:-${color8:-${color0:-$background}}}Test plan
[colors.selection]generatedselection == foreground(#cdd6f4)selection == color8(#585b70)[colors.selection].backgroundstill winstest/shell.d/theme-colors-from-alacritty-test.shpasses