Let status OSD messages use available screen width - #9260
Open
kevinherron wants to merge 1 commit into
Open
Conversation
A status message was cut off at a fixed 190sp, so a long app name or audio sink description elided on an ultrawide with room to spare. Bound it by half the output width minus the card's chrome instead, keeping the old width as a floor for narrow screens. Media OSDs keep their fixed cap: track metadata is unbounded and changes on every track, and the card should not resize with it. The card's frame comes from BorderSurface's padding and content insets now, so its width, height, row margins, and the cap's chrome share one definition instead of each adding `pad` to the borders by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status OSD messages currently cap text at 190sp. This truncates long application names and audio output descriptions even when wider displays have plenty of room.
This sizes status-message text from the output width, allowing the card to grow to at most half the screen while preserving 190sp as its minimum cap. Media OSDs retain their fixed width because track metadata is unbounded and changes frequently. The card now derives its frame and row insets from
BorderSurface, so the width calculation and rendered chrome use the same geometry.Before
Launch message:
Audio sink message:
After
Launch message:
Audio sink message:
The progress OSD remains compact:
Deliberately overlong status text still elides at the half-screen ceiling: