Fix context menus for Wine tray items - #9245
Open
clementrog wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ContextMenumethod instead of trying to render/NO_DBUSMENUas a DBusMenuStatusNotifierWatcher, verify both its Wine id and/NO_DBUSMENUsentinel, then forward the click's screen coordinatesWhy
Battle.net running through GE-Proton registers a live status notifier item like this:
The current tray treats that sentinel as a real DBusMenu object. Right-clicking therefore logs DBus
UnknownMethoderrors and renders nothing, which also makes Battle.net'sExitaction inaccessible.The freedesktop Status Notifier Item specification defines
ContextMenu(INT x, INT y)for exactly this right-click fallback, with coordinates in screen space.Verification
bash test/shell.d/tray-test.shbash test/shell.d/tray-context-menu-test.sh./test/cli./test/all: both new tray test files pass in the full run. Seven unrelated host-environment checks initially failed; each was rerun successfully with its expected companion checkout or host access. The URL-checker absence case also passes with an isolated PATH, because this Omarchy machine already has the checker installed globally.wine-0x200d4-0and/NO_DBUSMENU, ran the exact helper from this branch, and visually confirmed the native menu opens with itsExitactionThe branch is rebased onto current
quattro.