Constrain Omawrite's save dialog - #9134
Closed
yashranaway wants to merge 1 commit into
Closed
Conversation
|
Thanks for looking into this. The 875x600 rule was only a workaround tested on my display, so I’m unsure it should become the default fix for everyone. Treat this as a mitigation and investigate the sizing issue in Omawrite/Qt instead? |
Contributor
Author
|
Agreed, 875x600 is too display-specific, so I am moving this fix into Omawrite's file-dialog implementation. |
Contributor
Author
|
Replaced by omacom/omawrite#39, which fixes the dialog in Omawrite instead of applying a display-specific Hyprland rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps Omawrite's save dialog inside scaled laptop displays. Fixes #9046.
<<<< AI wording below >>>>
Problem
Omawrite can create a 1231x950 save dialog on a 1280x832 logical display, clipping its title and action controls beyond the monitor work area.
Fix
Match only Omawrite's
Save Filewindow and apply the reporter-validated floating, centered 875x600 geometry.Verification
bash -n test/shell.d/omawrite-window-rule-test.shgit diff --checkluais not installed.