Tell contributors to search open PRs before writing a fix - #9095
Open
rdoupe wants to merge 1 commit into
Open
Conversation
AGENTS.md is the file upstream work is routed to, and it said nothing about checking whether a fix already exists. The lock screen losing password focus after suspend had four open PRs before a fifth was filed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019q6kd5nX4D8xS7jy7KJYtP
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AGENTS.mdis where upstream work lands —contributing.mdalready calls it "the authority on contributions", and #6718 makes the handoff explicit ("for upstream source work, clone and follow its AGENTS.md"). It says nothing about checking whether a fix already exists.The result: the lock screen losing password focus after suspend has four open PRs (#7164, #7592, #8560, #8869). I opened a fifth (#9089, now closed) before finding them. Four people fixed the same twenty lines and a maintainer has to compare all of them.
Why here and not
contributing.md#8609 and #6959 add duplicate-check guidance to
default/agents/skills/omarchy/contributing.md. Two problems with that location:omarchyskill, whose description says it excludes source development. An agent asked to write a fix correctly decides the skill doesn't apply and never loads the file — that is exactly what happened in my session, with the skill installed.contributing.mdoutright.AGENTS.mdis loaded by anyone working in the checkout, survives #6718, and is the file #6718 routes contributors to. #6959'sbug.ymlcheckbox remains the right control for the issue path; this covers the PR path.Change
A
# Pull Requestssection after# Git: search before writing, search twice with different wording, and when an open PR covers the change, add to it — confirm the bug, review the approach, contribute a missing test — instead of opening a competing one. Docs only, +13/−0, full lines per the file's own Style section.