Fix Copilot platform payload cleanup - #214
Open
jeremydixon22 wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR repairs GitHub Copilot CLI package cleanup by rebasing
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The new payload root matches the directory containing the files being pruned, the package revision is advanced, and the durable patch has been verified against the pinned upstream recipe under strict application semantics.
|
| Filename | Overview |
|---|---|
| pkgbuilds/github-copilot-cli/PKGBUILD | Correctly redirects existing cleanup operations to the nested native platform package and bumps the package revision. |
| pkgbuilds/github-copilot-cli/.omarchy/patches/0001-fix-platform-payload-cleanup.patch | Durably reproduces the cleanup-path correction during AUR synchronization, with strict replay verification reported. |
Reviews (1): Last reviewed commit: "Fix Copilot platform payload cleanup" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the dead cleanup block identified in #195.
_moddircurrently points at the package root, while the prebuild and platform payloads being pruned live undernode_modules/@github/copilot-linux-${_arch}. Pointing_moddirat that actual payload root makes the existing cleanup operations effective.The change is kept separate from #195 as requested there: it does not alter
arch=(). If #195 lands first, this branch will need a small rebase because both changes touch the same PKGBUILD and carry separate durable AUR patches.Verification:
github-copilot-cli1.0.80-1.1 successfully inarchlinux:base-develbin/package-worktree;patched/matchescurrent/patch --dry-run --fuzz=0omarchy-pkgs self-test,omarchy-release self-test, and package-scoped edge and stable release dry-runs in the Arch environment