This repository was archived by the owner on Aug 30, 2026. It is now read-only.
Exit on error - #46
Merged
Merged
Conversation
|
I think this is a great catch and I think a great implementation and use of the command, btw the issue in #29 should be fixed |
|
Yes, this makes for a very important addition. |
burno-lima
pushed a commit
to burno-lima/omakdot
that referenced
this pull request
May 15, 2026
Exit on error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If any of the (sub)commands in
install.shfail, the install script will continue to run and effectively hide the fact that something went wrong. Settingset -ewill make the bash script exit upon an error.Context: I was just testing #29 in an
arm64VM, and the installation ofmisefailed silently (because the current version does not have a code path forarm64); however, it appeared as if the installation had worked correctly and I got logged out at the end of it.Then, when I tried to log in again, the system would simply hang. Upon further inspection, I realized it was hanging on this prompt:
https://github.com/basecamp/omakub/blob/9c603cd1f72be4c8c1e4b02f2f12ac39359e81a4/defaults/bash/init#L4