Generalize boot.sh to support running any ref - #187
Conversation
With the changes from omacom/omakub#187 we can get by with a single boot script.
bb39f3a to
673dd0e
Compare
673dd0e to
b924397
Compare
This will enable running not only the `master` and `stable` branches, but also unmerged commits, so that we can easily test them.
Otherwise it'd try to check out the branch it's already on.
The only unique part here was setting `OMAKUB_REF`, but we can do that instead in https://github.com/basecamp/omakub-site/blob/32701d97e88e7e4b10c0abd35194e602b1dbd5d7/install-dev
b924397 to
2f15445
Compare
|
@dhh Curious to get your thoughts on this. I just updated the PR description to clarify that this would not take away the common case of running The goal is simply to support a similar mechanism for testing other changes that aren't merged to That said, let me know if you have any objections to this, so I can either try to address them or abort and close the PRs. |
|
How would you be able to test something that isn't on master through this? Wouldn't those PRs be on a separate cloned repo URL? |
|
In GitHub, fork repositories share the same underlying git data, i.e. commits from a fork can be viewed/fetched in the base repository. Branches and tags are scoped to individual repositories, but the underlying commits aren't - it's been that way since forks were introduced, and is foundational to the GitHub repository "network". So we're just leveraging that here. |
|
This is breaking the update script. Since you're no longer directly on the stable branch. Can you have a look at how we might fix this? And also how we might fix it for folks who've installed this in a way where update now won't run? |
|
I've opened #240 which I think should address this going forward. Unfortunately, I think folks who did a first-run install in v1.1.2 would have to manually run |
Generalize `boot.sh` to support running any ref
This will enable running not only the
masterandstablebranches 1, but also unmerged commits, for easier testing, e.g.The hope is this would provide a good way to have folks test things like #29 before they've been merged.
Additionally, together with:
it removes the need for a separate
boot-dev.shscript (which was nearly identical toboot.sh).Footnotes
Note:
stableandmasterwill still be runnable via the existingwget -qO- https://omakub.org/install | bashandwget -qO- https://omakub.org/install-dev | bashcommands, respectively. No workflow changes needed for those two common cases! ↩