Process custom apps in the Omarchy v4 branch - #118
Merged
Conversation
ApplyTheme only ran template.ProcessCustomApps in the pre-v4 path. On Omarchy v4 installs (isOmarchyV4) the dedicated v4 template renderer skipped it entirely, so templates in ~/.config/aether/custom/ were never generated. Run ProcessCustomApps in the v4 branch too, with the same warning-on- failure handling as the legacy path. All tests pass.
Saco93
force-pushed
the
fix/process-custom-apps-in-v4
branch
from
August 18, 2026 04:43
25ceb05 to
a12ea33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ApplyThemeonly rantemplate.ProcessCustomAppsin the pre-v4 path. On Omarchy v4 installs (isOmarchyV4), the dedicated v4 template renderer skipped it entirely, so any templates a user placed in~/.config/aether/custom/were silently never generated.Changes
internal/theme/writer.go: runtemplate.ProcessCustomApps(themeDir, variables)in the v4 path too, with the same warning-on-failure handling as the legacy path.Verification
make testpasses (all internal + cli packages).go vetclean.