feat(linter): warn on social action approval gaps#1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45b25f954e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (SOCIAL_ACTION_RE.test(actionText) && !APPROVAL_BOUNDARY_RE.test(actionText)) { | ||
| addIssue('warning', 'action-approval-boundary-missing', 'Skill appears to drive social or browser actions but does not mention an explicit approval or no-submit boundary'); |
There was a problem hiding this comment.
The new rule is only added in src, but the shipped entry points still execute the committed build output: action.yml runs dist/index.js, and package.json points both main and bin at dist. In this commit dist/linter.js still has no action-approval-boundary-missing or SOCIAL_ACTION_RE, so GitHub Action/npm CLI users never see the new warning and fail-on: warnings will not behave as documented until the rebuilt dist files are committed.
Useful? React with 👍 / 👎.
|
Pushed e8f86d2 to flag negated social approval wording and rebuilt dist/linter.js for the GitHub Action entrypoint. Validation: npm test, npm run build, git diff --check. |
1 participant
Summary
Validation
npm test -- --runInBandnpm run lintgit diff --checkNotes
npm cireported existing dependency audit findings before the tests ran; this PR does not change dependencies.