feat(types): add Audio class and audio field to Message for multimodal models#654
Open
Ghraven wants to merge 1 commit intoollama:mainfrom
Open
feat(types): add Audio class and audio field to Message for multimodal models#654Ghraven wants to merge 1 commit intoollama:mainfrom
Ghraven wants to merge 1 commit intoollama:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
Audioclass andaudiofield toMessage, mirroring the existingImagepattern.Closes #650
Motivation
Currently, audio data must be passed via the
imageskey, which is confusing and blocks future models that support both images and audio simultaneously. This PR adds a first-classaudiofield so callers can pass audio data cleanly:Changes
ollama/_types.pyAdded
Audio(BaseModel)class afterImage, with identical serialisation logic:Path/bytes→ base64-encodes the datastrpath that exists on disk → base64-encodes the filestrwith a known audio extension that doesn't exist → raisesValueErrorwith a clear messagestrthat looks like existing base64 → passes throughValueErrormp3,mp4,mpeg,mpga,m4a,ogg,wav,webmAdded
audio: Optional[Sequence[Audio]] = Nonefield toMessage(afterimages), with the same docstring style asimages.Compatibility
audiois optional and defaults toNoneImage, so the wire format is already what the Ollama server expects (raw base64)