refactor(fast_io): re-fold SEC-1 *at* helpers into single at_syscalls module#4700
Open
oferchen wants to merge 1 commit into
Open
refactor(fast_io): re-fold SEC-1 *at* helpers into single at_syscalls module#4700oferchen wants to merge 1 commit into
oferchen wants to merge 1 commit into
Conversation
… module
Consolidates `at_syscalls_metadata.rs` (SEC-1.i) and `at_syscalls_rename.rs`
(SEC-1.j) into the existing `at_syscalls.rs` now that all three SEC-1 *at*
helper PRs are on master. The original module headers committed to a
re-fold once siblings landed; this completes the hygiene follow-up.
- Move metadata helpers (fchmodat / fchownat / utimensat plus their
via_sandbox_or_fallback adaptors and tests) under a SEC-1.i divider.
- Move rename helpers (renameat plus its via_sandbox_or_fallback adaptor
and tests) under a SEC-1.j divider. Keep the `RENAME_NOREPLACE` const
alongside the helpers that consume it.
- Drop the two duplicated `single_component_leaf` private helpers that
the sibling files carried for in-flight isolation; the original lives
in `at_syscalls.rs` and is shared by every adaptor.
- Collapse the dir_sandbox/mod.rs re-exports into a single alphabetical
`pub use at_syscalls::{...}` block.
- Delete `at_syscalls_metadata.rs` and `at_syscalls_rename.rs`.
Zero behaviour changes. All public helper names, signatures, gating, and
the lib.rs re-export surface are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates
at_syscalls_metadata.rs(SEC-1.i) andat_syscalls_rename.rs(SEC-1.j) into the existingat_syscalls.rsnow that all three SEC-1*athelper PRs (.h #4683, .i #4690, .j #4693) are on master. The original module headers explicitly committed to a re-fold once siblings landed; this completes the hygiene follow-up planned indocs/design/sec-1-at-syscalls-refold-2026-05-21.md.fchmodat/fchownat/utimensatplus theirvia_sandbox_or_fallbackadaptors and tests) under aSEC-1.idivider.renameatplus itsvia_sandbox_or_fallbackadaptor and tests) under aSEC-1.jdivider. TheRENAME_NOREPLACEconst stays alongside the helpers that consume it.single_component_leafprivate helpers that the sibling files carried for in-flight isolation; the original inat_syscalls.rsis shared by every adaptor.dir_sandbox/mod.rsre-exports into a single alphabeticalpub use at_syscalls::{...}block.at_syscalls_metadata.rsandat_syscalls_rename.rs.Zero behaviour changes. All public helper names, signatures, cfg gating, and the
lib.rsre-export surface are preserved. Net delta: +1081 / -1206 LoC (deduped private helpers + module-doc headers + test-helper duplication).Test plan
fast_iodir_sandboxremains#[cfg(unix)]atlib.rs; Windows compile-out is unchanged