Skip to content

feat(core): v0.2 failure detection rules — 7 new rules #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sepehr-safari merged 1 commit into from
Jul 8, 2026
Merged

feat(core): v0.2 failure detection rules — 7 new rules #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/toolkit/src/core/__fixtures__/connector-fault.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,16 @@ export default {
direction: 'CSMS_TO_CS',
message: [3, 'msg-006', {}],
},
{
timestamp: '2024-01-15T12:07:30.000Z',
direction: 'CS_TO_CSMS',
message: [2, 'msg-hb-1', 'Heartbeat', {}],
},
{
timestamp: '2024-01-15T12:07:30.500Z',
direction: 'CSMS_TO_CS',
message: [3, 'msg-hb-1', { currentTime: '2024-01-15T12:07:30.500Z' }],
},
{
timestamp: '2024-01-15T12:15:00.000Z',
direction: 'CS_TO_CSMS',
Expand Down Expand Up @@ -210,7 +220,7 @@ export default {
idTag: 'SYNTHETIC-TAG-002',
meterStop: 3500,
timestamp: '2024-01-15T12:18:05.000Z',
reason: 'Faulted',
reason: 'Other',
},
],
},
Expand Down
10 changes: 10 additions & 0 deletions packages/toolkit/src/core/__fixtures__/normal-session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,16 @@ export default {
direction: 'CSMS_TO_CS',
message: [3, 'msg-006', {}],
},
{
timestamp: '2024-01-15T10:07:30.000Z',
direction: 'CS_TO_CSMS',
message: [2, 'msg-hb-1', 'Heartbeat', {}],
},
{
timestamp: '2024-01-15T10:07:30.500Z',
direction: 'CSMS_TO_CS',
message: [3, 'msg-hb-1', { currentTime: '2024-01-15T10:07:30.500Z' }],
},
{
timestamp: '2024-01-15T10:15:00.000Z',
direction: 'CS_TO_CSMS',
Expand Down
303 changes: 303 additions & 0 deletions packages/toolkit/src/core/detection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,4 +441,307 @@ describe('detectFailures', () => {
expect(failures.some((f) => f.code === 'CONNECTOR_FAULT')).toBe(true);
});
});

// -------------------------------------------------------------------------
// v0.2 detection rules
// -------------------------------------------------------------------------

describe('TIMEOUT_NO_HEARTBEAT', () => {
it('detects missing heartbeat when trace spans beyond threshold', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'BootNotification', {}, 0),
makeEvent(
'e2',
'm1',
'CallResult',
null,
{ interval: 300, status: 'Accepted' },
500,
'CSMS_TO_CS',
),
// No heartbeat, but events span beyond 600s (2x300)
makeEvent('e3', 'm2', 'Call', 'StatusNotification', { status: 'Available' }, 700_000),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'TIMEOUT_NO_HEARTBEAT')).toBe(true);
});

it('does not flag when heartbeat is present', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'BootNotification', {}, 0),
makeEvent(
'e2',
'm1',
'CallResult',
null,
{ interval: 300, status: 'Accepted' },
500,
'CSMS_TO_CS',
),
makeEvent('e3', 'm2', 'Call', 'Heartbeat', {}, 100_000),
makeEvent('e4', 'm2', 'CallResult', null, {}, 100_500, 'CSMS_TO_CS'),
makeEvent('e5', 'm3', 'Call', 'StatusNotification', { status: 'Available' }, 700_000),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'TIMEOUT_NO_HEARTBEAT')).toBe(false);
});

it('does not flag when trace ends before first heartbeat is due', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'BootNotification', {}, 0),
makeEvent(
'e2',
'm1',
'CallResult',
null,
{ interval: 300, status: 'Accepted' },
500,
'CSMS_TO_CS',
),
// Trace ends at 100s — before 600s threshold
makeEvent('e3', 'm2', 'Call', 'StatusNotification', { status: 'Available' }, 100_000),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'TIMEOUT_NO_HEARTBEAT')).toBe(false);
});

it('does not flag when no BootNotification', () => {
const events = [makeEvent('e1', 'm1', 'Call', 'Heartbeat', {}, 0)];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'TIMEOUT_NO_HEARTBEAT')).toBe(false);
});
});

describe('METER_VALUE_GAP', () => {
it('detects missing MeterValues in completed transaction', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'StartTransaction', { connectorId: 1, transactionId: 1 }, 0),
makeEvent('e2', 'm1', 'CallResult', null, { transactionId: 1 }, 500, 'CSMS_TO_CS'),
makeEvent(
'e3',
'm2',
'Call',
'StopTransaction',
{ transactionId: 1, reason: 'EVDisconnected' },
10_000,
),
makeEvent('e4', 'm2', 'CallResult', null, {}, 10_500, 'CSMS_TO_CS'),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'METER_VALUE_GAP')).toBe(true);
});

it('does not flag when MeterValues are present', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'StartTransaction', { connectorId: 1, transactionId: 1 }, 0),
makeEvent('e2', 'm1', 'CallResult', null, { transactionId: 1 }, 500, 'CSMS_TO_CS'),
makeEvent('e3', 'm2', 'Call', 'MeterValues', { connectorId: 1, transactionId: 1 }, 5_000),
makeEvent('e4', 'm2', 'CallResult', null, {}, 5_500, 'CSMS_TO_CS'),
makeEvent(
'e5',
'm3',
'Call',
'StopTransaction',
{ transactionId: 1, reason: 'EVDisconnected' },
10_000,
),
makeEvent('e6', 'm3', 'CallResult', null, {}, 10_500, 'CSMS_TO_CS'),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'METER_VALUE_GAP')).toBe(false);
});
});

describe('INVALID_STOP_REASON', () => {
it('detects invalid stop reason', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'StopTransaction',
{ transactionId: 1, reason: 'BadReason' },
0,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'INVALID_STOP_REASON')).toBe(true);
});

it('does not flag valid stop reason', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'StopTransaction',
{ transactionId: 1, reason: 'EVDisconnected' },
0,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'INVALID_STOP_REASON')).toBe(false);
});
});

describe('UNEXPECTED_START', () => {
it('detects StartTransaction without BootNotification or Authorize', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'StartTransaction', { connectorId: 1 }, 0),
makeEvent('e2', 'm1', 'CallResult', null, { transactionId: 1 }, 500, 'CSMS_TO_CS'),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'UNEXPECTED_START')).toBe(true);
});

it('does not flag when BootNotification precedes StartTransaction', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'BootNotification', {}, 0),
makeEvent('e2', 'm1', 'CallResult', null, { status: 'Accepted' }, 500, 'CSMS_TO_CS'),
makeEvent('e3', 'm2', 'Call', 'StartTransaction', { connectorId: 1 }, 1000),
makeEvent('e4', 'm2', 'CallResult', null, { transactionId: 1 }, 1500, 'CSMS_TO_CS'),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'UNEXPECTED_START')).toBe(false);
});
});

describe('STATUS_TRANSITION_VIOLATION', () => {
it('detects illegal transition from Available to Finishing', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'StatusNotification',
{ connectorId: 1, status: 'Available' },
0,
),
makeEvent(
'e2',
'm2',
'Call',
'StatusNotification',
{ connectorId: 1, status: 'Finishing' },
1000,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'STATUS_TRANSITION_VIOLATION')).toBe(true);
});

it('does not flag valid transition from Available to Preparing', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'StatusNotification',
{ connectorId: 1, status: 'Available' },
0,
),
makeEvent(
'e2',
'm2',
'Call',
'StatusNotification',
{ connectorId: 1, status: 'Preparing' },
1000,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'STATUS_TRANSITION_VIOLATION')).toBe(false);
});
});

describe('DIAGNOSTICS_FAILURE', () => {
it('detects UploadFailed diagnostics status', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'DiagnosticsStatusNotification',
{ status: 'UploadFailed' },
0,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'DIAGNOSTICS_FAILURE')).toBe(true);
});

it('detects DiagnosisFailed diagnostics status', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'DiagnosticsStatusNotification',
{ status: 'DiagnosisFailed' },
0,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'DIAGNOSTICS_FAILURE')).toBe(true);
});

it('does not flag Uploaded diagnostics status', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'DiagnosticsStatusNotification', { status: 'Uploaded' }, 0),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'DIAGNOSTICS_FAILURE')).toBe(false);
});
});

describe('FIRMWARE_UPDATE_FAILURE', () => {
it('detects DownloadFailed firmware status', () => {
const events = [
makeEvent(
'e1',
'm1',
'Call',
'FirmwareStatusNotification',
{ status: 'DownloadFailed' },
0,
),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'FIRMWARE_UPDATE_FAILURE')).toBe(true);
});

it('detects InstallFailed firmware status', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'FirmwareStatusNotification', { status: 'InstallFailed' }, 0),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'FIRMWARE_UPDATE_FAILURE')).toBe(true);
});

it('does not flag Downloaded firmware status', () => {
const events = [
makeEvent('e1', 'm1', 'Call', 'FirmwareStatusNotification', { status: 'Downloaded' }, 0),
];
const sessions = buildSessionTimeline(events);
const failures = detectFailures(events, sessions);
expect(failures.some((f) => f.code === 'FIRMWARE_UPDATE_FAILURE')).toBe(false);
});
});
});
Loading
Loading