fix(ci): remove pnpm version conflict + bump Node to 24 - #17
Merged
Conversation
- Remove explicit pnpm version from action-setup (read from packageManager field in package.json instead — avoids ERR_PNPM_BAD_PM_VERSION) - Bump Node.js from 22 to 24 (Node 20 is deprecated on GitHub Actions, actions are being forced to Node 24)
sepehr-safari
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two CI issues:
pnpm version conflict —
pnpm/action-setup@v4hadversion: 10which conflicted withpackageManager: pnpm@10.16.1in package.json. Removed the explicit version — the action now reads frompackageManager.Node 20 deprecation — GitHub Actions deprecated Node 20. Bumped
node-versionfrom 22 to 24 to align with the forced runtime.Changes
.github/workflows/ci.yml— removedversion: 10from pnpm setup, bumped Node to 24.github/workflows/release.yml— same fixesVerification
packageManagerfield (single source of truth)