feat(inline-text-list-item): add strikethroughColor for the struck value#1091
Merged
Merged
Conversation
Adds an optional `strikethroughColor` to OceanInlineTextList to control the color of `value` when it is struck through (i.e. when `newValue` is present). Until now this color was hardcoded to `interfaceDarkDown` and the public `color` prop was ignored in that case. When `strikethroughColor` is null the component keeps using `interfaceDarkDown`, so the change is fully backward-compatible. Adds a preview demonstrating the new prop. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FabioRolin
force-pushed
the
feat/inline-text-list-strikethrough-color
branch
from
70ac973 to
857fedc
Compare
|
gustavoalens
approved these changes
Jun 3, 2026
vromeiro
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
No
OceanInlineTextListItem, quando o item temnewValue, ovalueé renderizado riscado e a sua cor estava hardcoded eminterfaceDarkDown— o prop públicocoloré usado para o conteúdo ativo (ícone,valuesemnewValuee o próprionewValue), mas não para ovalueriscado.Um app consumidor (PagBlu / blu-mobile-android) precisa que o
valueriscado usecolorInterfaceDarkUp(alinhado a Web/iOS), o que hoje não é possível via API.Recorder
Screen_recording_20260603_162341.webm
Mudança
strikethroughColor: String?emOceanInlineTextList(token Ocean, ex.:"colorInterfaceDarkUp").OceanInlineTextListItempassa a usarstrikethroughColorna cor dovalueriscado; quando nulo, mantéminterfaceDarkDown.strikethroughColor, o comportamento é idêntico ao atual.Uso
Verificação
./gradlew :ocean-components:compileDebugKotlin→ BUILD SUCCESSFUL.🤖 Generated with Claude Code