feat(transaction-list-expandable): expose isInverted on parent and children#1085
Draft
acassiovilasboas wants to merge 2 commits into
Draft
feat(transaction-list-expandable): expose isInverted on parent and children#1085acassiovilasboas wants to merge 2 commits into
acassiovilasboas wants to merge 2 commits into
Conversation
…ildren Adds isInverted flag to OceanTransactionListExpandableItem and propagates to the underlying OceanTransactionListItem in both OceanParentTransactionListExpandable and OceanChildTransactionListExpandable. Each item carries its own flag (no parent → child coupling), so callers can invert the parent, the children, or both independently. Updates the Compose preview and the TransactionListItemActivity sample with a default vs. inverted scenario. Refs BAN-57. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The expandable inverted scenario belongs alongside the other OceanTransactionListExpandable samples, not in the item activity. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Estende o flag
isInverted(introduzido emOceanTransactionListItem) ao componente expandable, cobrindo tanto o parent (OceanParentTransactionListExpandable) quanto os children (OceanChildTransactionListExpandable).isInverted: Boolean = falseemOceanTransactionListExpandableItem.item.isInvertedpara oOceanTransactionListIteminterno em ambos os wrappers.OceanTransactionListExpandablePreviewe oTransactionListItemActivitycom um cenário default e um invertido lado a lado para validação visual.Contexto
Origem: PR Pagnet/blu-mobile-android#3632 (extrato com
isInvertednoOceanTransactionListItemdireto). Os agrupamentosCOLLAPSE_GROUPficaram fora do escopo porque o expandable ainda não expunha o parâmetro. Esta PR fecha esse gap. Próxima PR no consumer (Pagnet/blu-mobile-android) bumpa a versão e passaisInverted = trueno helper doExtractFragment.Notas de implementação
isInvertedvs.primaryLabelStyle/secondaryLabelStyleexplícitos já está correta noOceanTransactionListItem(ver linhas 188–208) —isInvertedvence sobre os styles passados explicitamente. Sem ajuste extra necessário no item base.falseem todas as superfícies novas → retrocompat total. Nenhum consumer existente doOceanTransactionListExpandablemuda comportamento.Test plan
OceanTransactionListExpandablePreviewrenderiza o novo bloco com:primaryLabelemOceanTextStyle.description+OceanColors.interfaceDarkDown;secondaryLabelemOceanTextStyle.paragraph+OceanColors.interfaceDarkDeep. Mantém o chevron up/down.primaryLabel/secondaryLabel, com o leading icon do grupo, valor emheading5e divider interno entre filhos preservados.isInverted = false) acima permanecem visualmente idênticos ao comportamento atual.TransactionListItemActivityexibe o novo expandable invertido após o bloco existente, sem regressão nos itens de cima.Before
After
Refs
isInvertednoOceanTransactionListItemPagnet/blu-mobile-android(após release com este merge)