driver: Use Findlib's own logic for inferring directories - #1474
Open
katrinafyi wants to merge 4 commits into
Open
driver: Use Findlib's own logic for inferring directories#1474katrinafyi wants to merge 4 commits into
katrinafyi wants to merge 4 commits into
Conversation
As of about 2 years ago, ocamlfind is able to automatically infer the config path from opam environment variables: https://github.com/ocaml/ocamlfind/blob/be2335f14cc45b5551dea4278affdfb2718eb72e/src/findlib/findlib_config.mlp#L71-L77 This removes the explicitly provided arguments and will be more reliable than hardcoding a subpath of the opam prefix. Also, hardcoding the `env_camllib` can be risky because it's not portable. On openSUSE Tumbleweed, my stdlib was actually in `{prefix}/lib64` rather than the `lib/ocaml` which was hardcoded.
jonludlam
added
the
no changelog
Member
|
Thanks! I just put 'no changelog required' on this PR, but thinking about it, it's fixing a real bug that you found and that others might too - in which case it'd be useful to create an issue then have a changelog referencing it. Could you do that please? |
jonludlam
removed
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the explicitly provided arguments and will be more reliable than hardcoding a subpath of the opam prefix.
As of about 2 years ago, ocamlfind is able to automatically infer the config path from opam environment variables: https://github.com/ocaml/ocamlfind/blob/be2335f14cc45b5551dea4278affdfb2718eb72e/src/findlib/findlib_config.mlp#L71-L77
Also, hardcoding the
env_camllibcan be risky because it's not portable or overridable. On openSUSE Tumbleweed, my stdlib was actually in{prefix}/lib64rather than thelib/ocamlwhich was hardcoded.Findlib also has logic to let the user override the paths using environment variables, if needed: https://github.com/ocaml/ocamlfind/blob/be2335f14cc45b5551dea4278affdfb2718eb72e/src/findlib/findlib.ml#L281-L289