scheduler: route file watcher events through a fiber channel#14778
Open
rgrinberg wants to merge 1 commit into
Open
scheduler: route file watcher events through a fiber channel#14778rgrinberg wants to merge 1 commit into
rgrinberg wants to merge 1 commit into
Conversation
rgrinberg
force-pushed
the
push-yonkvokymlln
branch
5 times, most recently
from
0b1bcbc to
7018617
Compare
Add a thread-safe channel for delivering values from watcher threads to fibers, and use it to make File_watcher expose read, flush, and close operations instead of pushing raw filesystem events through Scheduler.Event.Queue. Move filesystem-event handling and Fs_memo initialization into the build loop, so the scheduler event queue only needs to handle memo invalidations, worker/job notifications, and shutdown. Add expect coverage for the thread-safe channel and update file watcher tests to use a test event sink. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> scheduler: simplify file watcher invalidation plumbing Combine queued build-input invalidations before delivering them to the scheduler, so Build_inputs_changed carries one invalidation. Keep sync ids private to File_watcher and store pending flush ivars directly in the sync table, removing the separate pending-sync table. Remove duplicated build-loop file-watcher state and narrow Fs_memo watcher hooks under a build-loop-facing submodule. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> scheduler: factor thread-safe channel wakeups Signed-off-by: Rudi Grinberg <me@rgrinberg.com> scheduler: hide thread-safe channel fill writes Signed-off-by: Rudi Grinberg <me@rgrinberg.com> scheduler: localize file watcher event batching Signed-off-by: Rudi Grinberg <me@rgrinberg.com> test: construct thread-safe channel with local queue Signed-off-by: Rudi Grinberg <me@rgrinberg.com> scheduler: remove test-only channel wrapper Signed-off-by: Rudi Grinberg <me@rgrinberg.com> scheduler: inline channel wakeup helper Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-yonkvokymlln
branch
from
7018617 to
88a09f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a thread-safe channel for delivering values from watcher threads to fibers, and use it to make File_watcher expose read, flush, and close operations instead of pushing raw filesystem events through Scheduler.Event.Queue.
Move filesystem-event handling and Fs_memo initialization into the build loop, so the scheduler event queue only needs to handle memo invalidations, worker/job notifications, and shutdown.
Add expect coverage for the thread-safe channel and update file watcher tests to use a test event sink.
scheduler: simplify file watcher invalidation plumbing
Combine queued build-input invalidations before delivering them to the scheduler, so Build_inputs_changed carries one invalidation.
Keep sync ids private to File_watcher and store pending flush ivars directly in the sync table, removing the separate pending-sync table.
Remove duplicated build-loop file-watcher state and narrow Fs_memo watcher hooks under a build-loop-facing submodule.