sms_tool: make USSD response decoding robust - #24
Open
dormancygrace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sscanf()parsing of+CUSDwith a bounded parser-cas an authoritative manual overrideWhy
Issue #13 contains a valid UCS2 response reported with DCS 7 by the modem.
The old code decoded it as packed GSM-7 unless the user supplied
-c 2.The USSD part of #1 also remained limited to one-line responses, and the old
unbounded scans could overflow the 320-byte payload buffer (the sample from
#13 is already 496 hex characters).
This completes the unresolved USSD portions of #1 and #13 while keeping the
existing manual workaround available.
Validation
-c-c 2still decodes the same responsegit diff --check