Split long messages into concatenated SMS parts - #22
Open
dormancygrace wants to merge 2 commits into
Open
Conversation
Encode non-ASCII UTF-8 input as UCS-2. Normalize leading plus signs in international numbers. Reject malformed input instead of submitting a broken PDU. Add deterministic ASCII and UCS-2 submit test vectors. Make the send path propagate encoding and modem errors.
Add concatenated SMS submission with an 8-bit UDH reference. Use 153 septets per GSM-7 part and 67 characters per UCS-2 part. Keep GSM extension pairs together at part boundaries. Add multipart packing, boundary and 255-part limit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a separate follow-up to #21 and currently stacks on that PR. Once #21
is merged, GitHub will show only the multipart commit here.
Validation
The hardware test sent a 121-character Cyrillic message as two parts. The
modem accepted them as
+CMGS: 10and+CMGS: 11; the receiving phonereassembled both parts into one message with the exact original text.