Add CJK font fallbacks (Japanese / Simplified Chinese) - #7
Merged
Conversation
DM Sans and the mono stack have no CJK coverage; Japanese and Chinese content (builder names, descriptions, future translations) was falling through to whatever system font the OS picked. Adds Hiragino/Yu Gothic/Noto JP for Japanese, PingFang/Noto SC/YaHei for Simplified Chinese to the sans and display stacks, and Noto Sans Mono CJK JP to the mono stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-stack-line fix: the font stacks had no CJK coverage, so Japanese and Chinese text rendered in whatever system font the OS substituted. Adds proper JP/SC fallbacks to sans, display, and mono stacks. No visual change for Latin text; CJK content now renders in intentional, consistent typefaces.