Skip to content

Fix tracker time increasing issue - #78

Open
zwdoescode wants to merge 1 commit into
mainfrom
zheng/fix-gh-77
Open

Fix tracker time increasing issue#78
zwdoescode wants to merge 1 commit into
mainfrom
zheng/fix-gh-77

Conversation

@zwdoescode

@zwdoescode zwdoescode commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Fix issue #77

Summary by CodeRabbit

  • Bug Fixes
    • Improved stability when tracking poses and trajectory data concurrently.
    • Reduced the risk of inconsistent pose results during simultaneous tracking and pose retrieval.
    • Improved handling of keyframe and frame-pose updates under concurrent operations.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 925cf578-6c12-4089-aa1e-ac988ae19ea9

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2463f and c729b74.

📒 Files selected for processing (2)
  • libs/slam/async_slam/async_slam.cpp
  • libs/slam/async_slam/async_slam.h

📝 Walkthrough

Walkthrough

AsyncSlam adds mutex protection for shared tracking state and trajectory data. Update paths write and snapshot state under the mutex. Pose query methods copy shared data under the mutex before processing.

Changes

Pose-state synchronization

Layer / File(s) Summary
Pose-state guard and update paths
libs/slam/async_slam/async_slam.h, libs/slam/async_slam/async_slam.cpp
Adds pose_state_mutex_ and documents guarded members. TrackResult and keyframe processing update tracking state and trajectory data under the mutex.
Synchronized pose reads
libs/slam/async_slam/async_slam.cpp
GetSlamPose, GetPoseForFrame, and GetPosesForAllFrames copy shared state or trajectory data under the mutex before processing.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: hrabeti-nvidia, slepichev, vikuznetsov-nvidia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the tracker time issue addressed by the pull request and matches the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch zheng/fix-gh-77

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Test Results

Status Platform Language Total Passed Failed Errors Skipped
Orin C++ 16 16 0 0 0
Orin Python 71 70 0 0 1
Thor C++ 16 16 0 0 0
Thor Python 71 70 0 0 1
x86_64 C++ 16 16 0 0 0
x86_64 Python 71 70 0 0 1

cuVSLAM Evaluation KPIs

Config Dataset ATE,% ARE,º/m Kabsch, Losts, diff ATE,% diff ARE,º/m diff Kabsch, diff Losts, FPS,Hz
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_ODOM 0.8486 0.0024 2.9525 0 NA NA NA NA 324.4
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_SLAM 0.7549 0.002 1.9098 0 NA NA NA NA 181.9

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant