fix(theme): replace deprecated bare tailwind aliases - #6865
Conversation
--ui-radius|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe theme updates replace Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized theme-class updates to align radius and blur aliases with the current styling configuration; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
❓ Type of change
📚 Description
The
segmentslot ofInputDateandInputTimeused the bareroundedclass. That's the v3 alias, and Tailwind keeps it alive through a deprecated theme variable:src/templates.tsonly maps--radius-xsthrough--radius-3xlontovar(--ui-radius), so--radiusis never remapped and the segments were pinned to a literal0.25rem:Every other slot in those components already scales (
baseusesrounded-md), so with--ui-radius: 0the segments stayed rounded, and raising it left them behind.rounded-smis byte-identical at the default0.25rem, so this only changes anything for non-default radius values.Worth noting
rounded-xsis the wrong target here: the v3 → v4 rename moved v3'srounded-smtorounded-xsand v3's bareroundedtorounded-sm, sorounded-xswould halve the radius tocalc(var(--ui-radius) * 0.5).While in there, I swept
src/theme/for other bare deprecated aliases and foundbackdrop-blurinChatPrompt,ContentToc,HeaderandTable. Those aren't token-backed (--blurand--blur-smare both8pxand neither is remapped), sobackdrop-blur-smis a pure no-op there, included just so no bare alias is left.src/theme/is now clean ofrounded,shadow,drop-shadow,blur,backdrop-blurandinset-shadowin their bare forms.Both renames are in-group in
tailwind-merge@3.6.0in both directions, so consumer overrides can't silently break:The snapshot diff is large but entirely mechanical. I checked that all 1268 changed lines are the old line with only those two tokens renamed, nothing structural moved.
📝 Checklist