Skip to content

fix(theme): replace deprecated bare tailwind aliases - #6865

Merged
benjamincanac merged 1 commit into
v4from
fix/input-date-time-segment-radius
Aug 20, 2026
Merged

fix(theme): replace deprecated bare tailwind aliases#6865
benjamincanac merged 1 commit into
v4from
fix/input-date-time-segment-radius

Conversation

@benjamincanac

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The segment slot of InputDate and InputTime used the bare rounded class. That's the v3 alias, and Tailwind keeps it alive through a deprecated theme variable:

/* tailwindcss/theme.css */
@theme default inline reference {
  --radius: 0.25rem;
  ...
}

src/templates.ts only maps --radius-xs through --radius-3xl onto var(--ui-radius), so --radius is never remapped and the segments were pinned to a literal 0.25rem:

rounded     => border-radius: 0.25rem;
rounded-sm  => border-radius: var(--ui-radius);

Every other slot in those components already scales (base uses rounded-md), so with --ui-radius: 0 the segments stayed rounded, and raising it left them behind. rounded-sm is byte-identical at the default 0.25rem, so this only changes anything for non-default radius values.

Worth noting rounded-xs is the wrong target here: the v3 → v4 rename moved v3's rounded-sm to rounded-xs and v3's bare rounded to rounded-sm, so rounded-xs would halve the radius to calc(var(--ui-radius) * 0.5).

While in there, I swept src/theme/ for other bare deprecated aliases and found backdrop-blur in ChatPrompt, ContentToc, Header and Table. Those aren't token-backed (--blur and --blur-sm are both 8px and neither is remapped), so backdrop-blur-sm is a pure no-op there, included just so no bare alias is left. src/theme/ is now clean of rounded, shadow, drop-shadow, blur, backdrop-blur and inset-shadow in their bare forms.

Both renames are in-group in tailwind-merge@3.6.0 in both directions, so consumer overrides can't silently break:

rounded          + rounded-lg       -> rounded-lg
rounded-sm       + rounded          -> rounded
backdrop-blur    + backdrop-blur-sm -> backdrop-blur-sm
backdrop-blur-sm + backdrop-blur    -> backdrop-blur

The snapshot diff is large but entirely mechanical. I checked that all 1268 changed lines are the old line with only those two tokens renamed, nothing structural moved.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Aug 20, 2026
@benjamincanac benjamincanac changed the title fix(theme): scale InputDate and InputTime segments with --ui-radius fix(theme): replace deprecated bare Tailwind aliases Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52e3fd0b-6667-47c2-bcf7-c7dfb3b13bd2

📥 Commits

Reviewing files that changed from the base of the PR and between e2a253e and 2fa930e.

⛔ Files ignored due to path filters (11)
  • test/components/__snapshots__/ChatPrompt-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/ChatPrompt.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Header-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Header.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/InputDate-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/InputDate.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/InputTime-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/InputTime.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Table-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Table.spec.ts.snap is excluded by !**/*.snap
  • test/components/content/__snapshots__/ContentToc.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (6)
  • src/theme/chat-prompt.ts
  • src/theme/content/content-toc.ts
  • src/theme/header.ts
  • src/theme/input-date.ts
  • src/theme/input-time.ts
  • src/theme/table.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The theme updates replace backdrop-blur with backdrop-blur-sm in chat prompt, TOC, header, and table styles. Date and time input segments replace rounded with rounded-sm. Other styling classes remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 2fa93

This PR makes localized theme-class updates to align radius and blur aliases with the current styling configuration; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The pull request does not provide a linked issue or discussion, so issue-linking compliance cannot be confirmed. Link the pull request to the relevant issue or discussion, or state why no linked issue is required.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description accurately explains the radius scaling fix and the mechanical backdrop-blur alias replacements.
Out of Scope Changes check ✅ Passed All changes are limited to theme styling aliases and directly support the pull request objectives.
Title check ✅ Passed The title clearly identifies the replacement of deprecated bare Tailwind aliases, which is the primary change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/input-date-time-segment-radius

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Aug 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing fix/input-date-time-segment-radius (2fa930e) with v4 (e2a253e)

Open in CodSpeed

@pkg-pr-new

pkg-pr-new Bot commented Aug 20, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@6865

commit: 2fa930e

@benjamincanac benjamincanac changed the title fix(theme): replace deprecated bare Tailwind aliases fix(theme): replace deprecated bare tailwind aliases Aug 20, 2026
@benjamincanac
benjamincanac merged commit d4f2ca0 into v4 Aug 20, 2026
27 checks passed
@benjamincanac
benjamincanac deleted the fix/input-date-time-segment-radius branch August 20, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant