Skip to content

Fix #100: Accept int/float subclasses in QuadPrecision comparisons #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SwayamInSync wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #100: Accept int/float subclasses in QuadPrecision comparisons #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/csrc/scalar_ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ quad_richcompare(QuadPrecisionObject *self, PyObject *other, int cmp_op)
return NULL;
}
}
else if (PyLong_CheckExact(other) || PyFloat_CheckExact(other)) {
else if (PyLong_Check(other) || PyFloat_Check(other)) {
other_quad = QuadPrecision_from_object(other, backend);
if (other_quad == NULL) {
return NULL;
Expand Down
27 changes: 27 additions & 0 deletions tests/test_quaddtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,6 +1350,33 @@ def test_comparisons(op, a, b):
assert op_func(quad_a, quad_b) == op_func(float_a, float_b)


@pytest.mark.parametrize("op", ["eq", "ne", "le", "lt", "ge", "gt"])
@pytest.mark.parametrize(
"quad_val, other",
[
# bool is a subclass of int — exercises PyLong_Check (regression: gh-100)
(1, True),
(0, False),
(1, False),
(0, True),
(2, True),
# np.float64 is a subclass of float — exercises PyFloat_Check
(1, np.float64(1.0)),
(1, np.float64(2.0)),
(0, np.float64(-0.0)),
],
)
def test_comparisons_with_python_subclasses(op, quad_val, other):
op_func = getattr(operator, op)
quad_a = QuadPrecision(quad_val)
expected = op_func(float(quad_val), float(other))

# Forward: QuadPrecision OP subclass-instance
assert op_func(quad_a, other) == expected, f"Failed {op} between QuadPrecision({quad_val}) and {other} (type {type(other)})"
# Reverse: subclass-instance OP QuadPrecision
assert op_func(other, quad_a) == op_func(float(other), float(quad_val)), f"Failed {op} between {other} (type {type(other)}) and QuadPrecision({quad_val})"


@pytest.mark.parametrize("op", ["eq", "ne", "le", "lt", "ge", "gt"])
@pytest.mark.parametrize("a", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
@pytest.mark.parametrize("b", ["3.0", "12.5", "100.0", "0.0", "-0.0", "inf", "-inf", "nan", "-nan"])
Expand Down
Loading