videre-host: document handshake admission boundaries - #533
Merged
Conversation
mfw78
force-pushed
the
docs/519-handshake-admission-boundaries
branch
from
July 23, 2026 14:15
3a38002 to
774fbaa
Compare
Document the opt-in precondition on admit_worker/admit_provider (a manifest omitting [venue] is admitted unconditionally) and the post-instantiation, pre-init ordering of the registry export-divergence check.
mfw78
force-pushed
the
docs/519-handshake-admission-boundaries
branch
from
July 23, 2026 14:52
774fbaa to
654d37d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Doc-only change in
crates/videre-hostrecording two admission-boundary facts that the code already enforces but did not spell out.handshake.rs: a terse "Opt-in" rustdoc line on bothadmit_providerandadmit_workerstating that a manifest omitting[venue]is admitted unconditionally, an intentional silent opt-out for non-venue keepers.registry.rs: a comment beforeverify_exported_versions(afterVenueAdapter::instantiate_async) noting it runs post-instantiation, pre-init, so unlike the pre-compile manifest-section predicates insupervisor.rsa buggy or malicious adapter fully instantiates, running any instantiation side effects, before this divergence check catches the mismatch.No code behaviour changed.
Why
Both boundaries are load-bearing but non-obvious. The vacuous admit on absent
[venue]reads like a missing check rather than a deliberate opt-out, and the export-divergence check's ordering relative to instantiation determines whether adapter side effects can run before the mismatch is caught. Documenting them in place keeps the security-relevant intent next to the code that realizes it.Testing
cargo fmt --all -- --checkclean, andcargo clippy -p videre-host --all-targets --all-features -- -D warningsclean after a cold rebuild of the crate. Both run undernix develop(rustc 1.94.0). The vacuous opt-out is backed by the existingundeclared_sections_are_admittedtest; the ordering note matchesverify_exported_versionsrunning afterinstantiate_asyncand beforecall_init.AI Assistance
Implemented, reviewed and verified with Claude Code (Opus).
Closes #519